Re: [PATCH 5/7] network: Add function to set the WPS PIN and check its validity

[Julien Massot]

>
> The function is nice, but not in the right place. Put it in service.c (you
> could even merge this check code directly in your patch 6)
> network.c is not meant to do checks or whatever, it's a gateway between
> service and the technology plugin below, that's why this code should not be
> here.
>
> Ok for me I have hesitate between the two files, and finally I have
choosen the network.c because there is nothing about WPS in the service
structure.
I move this function to service.c and I remove the last patch 7.
_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman