Hi Patrik,

Sorry for late reply.

I made bugs report at https//bugs.meego.com/show_bug.cgi?id=25127.
Bug 25127 - Fix detect_dellink to destruct device when Wi-Fi is scanning.

Please make a reference to it.

Cheers,
Danny JS Seo.


> > After Wi-Fi scan, detect_dellink() cannot process device_destruct() 
> > because device is still made a reference.
> > 
> > So this patch can check __connman_device_reset_scanning() and deal 
> > with
> > connman_device_unref() correctly.

> I think some part of connman still has a reference for a reason.

> >         connman_device_unregister(device);
> >         connman_device_unref(device);
> > +
> > +       if (__connman_device_scanning(device) == TRUE) {
> > +               connman_device_reset_scanning(device);
> > +               connman_device_unref(device);
> > +       }
> > }

> Here we should not unref the device, since we're now unreffing it more than 
> the one and only reference we took when creating it. I'm not sure about > 
> stopping the scan either, scan should be stopped in wifi_remove() in 
> plugins/wifi.c when unregistering the device. And after all, the scanning 
> check should be done before the original unref, as the struct might be gone 
> at this point already.

> Do you have any description and log files of the unwanted connman behavior 
> you are trying to eliminate here?


> Cheers,

>       Patrik


_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to