Hello, as discussed in #connman, I'd like to know if it's desired to mark some of the false positives with assertions.
On Mon, May 14, 2012 at 4:58 AM, Jukka Rissanen <[email protected]> wrote: > Hi Henrique, > > some comments: > >> Dead store Dead assignment src /rtnl.c 837 1 View >> Report > > > False positive. Debugging print is disabled, probably will not be changed. > > >> Dead store Dead assignment tools /wispr.c 355 1 View >> Report > > > False positive. If we remove the len, then gcc will complain about the > write(). Probably not worth the fix. > > >> Logic error Dereference of null pointer gdhcp /client.c 1938 14 >> View Report > > > False positive. message_type cannot be null, commit > a7232d6f304455e2388279b4462de42f789f7b9d was added last week. The function > handles both the IPv4 and IPv6 packets but they have different states so > call flow cannot have message_type=NULL any longer. > > >> Logic error Dereference of null pointer gdhcp /client.c 2042 11 >> View Report > > > False positive. packet6 cannot be null, commit > 99cf044b1796c0698e58d6bb1f1647521a029e8e was added last week. > > >> Logic error Dereference of null pointer gdhcp /client.c 1918 14 >> View Report > > > False positive. See above explanation. > > >> Logic error Dereference of null pointer gdhcp /client.c 1978 11 >> View Report > > > False positive. Ditto. > > > Cheers, > Jukka > > > > > On 05/11/2012 03:57 PM, Henrique Dante wrote: >> >> Hello, I've just updated static analysis results at: >> >> http://people.profusion.mobi/~hdante/connman/index.html >> >> On Tue, May 8, 2012 at 3:06 PM, Henrique Dante<[email protected]> >> wrote: >>> >>> Hello, I'm sending the error reports here, as suggested in #connman. >>> There were 8 issues, 1 of them already solved (plugins/ofono.c). Here >>> are the other 7: >>> >>> Logic error Dereference of null pointer gdhcp /client.c 1933 >>> http://people.profusion.mobi/~hdante/connman/report-nynAB9.html >>> >>> Logic error Dereference of null pointer gdhcp /client.c 1973 >>> http://people.profusion.mobi/~hdante/connman/report-EozYdf.html >>> >>> Logic error Dereference of null pointer gdhcp /client.c 2037 >>> http://people.profusion.mobi/~hdante/connman/report-87D503.html >>> >>> Logic error Dereference of null pointer gdhcp /client.c 1913 >>> http://people.profusion.mobi/~hdante/connman/report-3dCysY.html >>> >>> Logic error Function call argument is an uninitialized value gweb /gweb.c >>> 615 >>> http://people.profusion.mobi/~hdante/connman/report-d6j0KB.html >>> >>> Logic error Dereference of null pointer src /session.c 1253 >>> http://people.profusion.mobi/~hdante/connman/report-uuU4ZT.html >>> >>> Logic error Dereference of null pointer src /session.c 1276 >>> http://people.profusion.mobi/~hdante/connman/report-xhYEku.html >>> >>> In the second and third reports, it looks like an invalid path was >>> reported, but I kept them anyway because I could find a small >>> variation where the bug would trigger. >> >> _______________________________________________ >> connman mailing list >> [email protected] >> http://lists.connman.net/listinfo/connman >> > _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
