Hi Julien,

> I don't expect that this patch will be applied
> but there is a problem here:
> 
> The DHCP server may provide wrong information,
> In this case we must not call dhcp_validate().
> 
> One of my customer has set an invalid netmask on his DHCP server.
> (255.255.2.0)
> And I have passed a lot of time to find the issue.
> 
> Having an error in the log could be helpful.

I am fine with logging this, but please use connman_warn() and not
connman_error() if we continue to use the wrong netmask.

Regards

Marcel


_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to