Hi Grant, On 07/16/2012 07:47 PM, Grant Erickson wrote:
This patch set is an omnibus roll-up of several patches submitted Friday and over the weekend to address BMC#25486 <https://bugs.meego.com/show_bug.cgi?id=25486>.Two key problems are addressed in this set: 1) The NTP client will send to a given server address up to four times at two second intervals before giving up and moving on to the next server. 2) The resolver will not allow unsuccessful A or AAAA response status to override successful status when performing a wildcard lookup (i.e. the address family is unspecified). Grant Erickson (13): ntp: add mnemonics for the flags (leap, version, mode) packet field ntp: use mnemonics rather than magic numbers ntp: send a transmit time value that reflects current system time ntp: specify leap-not-in-sync in flags ntp: use mnemonics when checking reply flags ntp: add mnemonics for common clock precisions ntp: use mnemonic when specifying the request precision ntp: retry a given server address multiple times before falling back ntp: fixed a debug message typo ntp: add debug message when starting NTP against resolved server gresolve: fix a typo in conditional check for returning results gresolv: do not allow unsuccessful response status to override successful status gresolv: use predefined mnemonics rather than magic numbers gweb/gresolv.c | 26 ++++++----- src/ntp.c | 131 +++++++++++++++++++++++++++++++++++++++++++----------- src/timeserver.c | 4 +- 3 files changed, 125 insertions(+), 36 deletions(-)
Looks great. Couple of patches had over 72 char line commit messages but the commiter can tweak that if necessary.
ACK from me. Cheers, Jukka _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
