Hi Fernando,
On 07/16/2012 01:16 PM, Fernando Herrera wrote:
---
src/clock.c | 14 ++++++++++++++
src/connman.h | 1 +
src/ntp.c | 1 +
3 files changed, 16 insertions(+)
diff --git a/src/clock.c b/src/clock.c
index e2cc19f..f3f118a 100644
--- a/src/clock.c
+++ b/src/clock.c
@@ -341,6 +341,20 @@ void __connman_clock_update_timezone(void)
DBUS_TYPE_STRING, &timezone_config);
}
+void __connman_clock_update_time(void)
What about optimizing this function a bit and having the timeval as a
parameter to this function, that way we would not need to do
gettimeofday() here because the caller already knows the time.
So something like this
void __connman_clock_update_time(struct timeval *tv)
{
dbus_uint64_t val = tv->tv_sec;
connman_dbus_property_changed_basic(CONNMAN_MANAGER_PATH,
CONNMAN_CLOCK_INTERFACE, "Time",
DBUS_TYPE_UINT64, &val);
}
+{
+ DBG("");
+
+ struct timeval tv;
+ if (gettimeofday(&tv, NULL) == 0) {
+ dbus_uint64_t val = tv.tv_sec;
+
+ connman_dbus_property_changed_basic(CONNMAN_MANAGER_PATH,
+ CONNMAN_CLOCK_INTERFACE, "Time",
+ DBUS_TYPE_UINT64, &val);
+ }
+}
+
int __connman_clock_init(void)
{
DBG("");
diff --git a/src/connman.h b/src/connman.h
index 6726078..0fb86c6 100644
--- a/src/connman.h
+++ b/src/connman.h
@@ -60,6 +60,7 @@ int __connman_clock_init(void);
void __connman_clock_cleanup(void);
void __connman_clock_update_timezone(void);
+void __connman_clock_update_time(void);
int __connman_timezone_init(void);
void __connman_timezone_cleanup(void);
diff --git a/src/ntp.c b/src/ntp.c
index 91a8832..5f66c57 100644
--- a/src/ntp.c
+++ b/src/ntp.c
@@ -229,6 +229,7 @@ static void decode_msg(void *base, size_t len, struct
timeval *tv)
}
DBG("%lu seconds, %lu msecs", cur.tv_sec, cur.tv_usec);
+ __connman_clock_update_time();
and here just
__connman_clock_update_time(&cur);
}
}
Cheers,
Jukka
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
