On 18.07.2012 13:58, Gustavo Sverzut Barbieri wrote:
the entire code above should be common to "case DT_DIR". An idea to
clean this up:
Add "case DT_UNKOWN" before "case DT_DIR" and let it fall-through
without a break statement if it's a dir.
meh... of course this doesn't work. But you should put together the
common part nonetheless. Maybe using a flag isdir and if/else it's
easier
I wonder why fstatat() then stat(). He should just do the fstatat() on the
final name, then concatenate the 2 path components.
And god, you know the size of path prefix, just join the strings wisely and
not sprintf it :-/
Obviously, I am happy to accept such patches :)
cheers,
daniel
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
