Hi,

Noticed a few things while testing:

client/cmn services --properties <service> produces a really sparse
output of the service properties. I'd like to have it similar to
test/list-services and client/cmn tech. It's also good to print empty
arrays and dictionaries as '[ ]' and '{ }' respectively.

client/cmn scan outputs 'Scan requires an argument, see help'. Since we
know a technology name is wanted, the message should be about that.

client/cmn scan ethernet will return an net.connman.Error.NotSupported
error containing a text string "Not supported", since ethernet does not
support scanning. Please print out the error and/or text and give some
other return value than zero. This might be true for other commands as
well, please check them also.

client/cmn scan foobar and client/cmn enable/disable foobar should
complain nicely that 'foobar' is an unknown technology and return an
appropriate non-zero value.

client/cmn state is heavily indented without any visible clues why.

client/cmn monitor could also just print out e.g. [Powered] = True just
like client/cmn tech does.

client/cmn monitor --services doesn't seem to be reacting to
ServicesChanged, it seems to only print out WiFi signal changes after a
while.


Despite the above, the command line client starts to be quite promising!


Cheers,

        Patrik


_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to