On Thu, 2012-08-30 at 17:00 +0530, Praveen C wrote:
> Was curious to understand the reason for this patch?
>From glib singly linked list documentation:
"Note that g_slist_append() has to traverse the entire list to find the
end, which is inefficient when adding multiple elements. A common idiom
to avoid the inefficiency is to prepend the elements and reverse the
list when all elements have been added."
In this case the patch touches those places I understand aren't
interesting in the list item ordering. The cases left with
g_slist_append() do either care about ordering or add the list items one
by one and thus the reversing trick cannot be used.
The patch is mostly nitpicking except for maybe the wifi plugin.
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
