Hi Jukka,
> src/iptables.c | 4 ++--
> src/stats.c | 10 +++++-----
> tools/iptables-test.c | 4 ++--
> tools/stats-tool.c | 4 ++--
> 4 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/src/iptables.c b/src/iptables.c
> index 43a2782..1ca8758 100644
> --- a/src/iptables.c
> +++ b/src/iptables.c
> @@ -1161,7 +1161,7 @@ static void iptables_dump(struct connman_iptables
> *table)
> table->info->valid_hooks, table->info->num_entries,
> table->info->size);
>
> - ENTRY_ITERATE(table->blob_entries->entrytable,
> + (void)ENTRY_ITERATE(table->blob_entries->entrytable,
> table->blob_entries->size,
> dump_entry, table);
why are we not doing anything with the result here?
> @@ -1290,7 +1290,7 @@ static struct connman_iptables *iptables_init(char
> *table_name)
> memcpy(table->hook_entry, table->info->hook_entry,
> sizeof(table->info->hook_entry));
>
> - ENTRY_ITERATE(table->blob_entries->entrytable,
> + (void)ENTRY_ITERATE(table->blob_entries->entrytable,
> table->blob_entries->size,
> add_entry, table);
>
> diff --git a/src/stats.c b/src/stats.c
> index dde5fca..a491260 100644
> --- a/src/stats.c
> +++ b/src/stats.c
> @@ -227,7 +227,7 @@ static void stats_free(gpointer user_data)
> munmap(file->addr, file->len);
> file->addr = NULL;
>
> - TFR(close(file->fd));
> + (void)TFR(close(file->fd));
> file->fd = -1;
And why are we not handling the result here either? At least we could
print a warning.
> if (file->history_name != NULL) {
> @@ -377,7 +377,7 @@ static int stats_file_setup(struct stats_file *file)
> connman_error("fstat error %s for %s\n",
> strerror(errno), file->name);
>
> - TFR(close(file->fd));
> + (void)TFR(close(file->fd));
> g_free(file->name);
> file->name = NULL;
>
> @@ -392,7 +392,7 @@ static int stats_file_setup(struct stats_file *file)
>
> err = stats_file_remap(file, size);
> if (err < 0) {
> - TFR(close(file->fd));
> + (void)TFR(close(file->fd));
> g_free(file->name);
> file->name = NULL;
>
> @@ -621,7 +621,7 @@ static int stats_file_close_swap(struct stats_file
> *history_file,
> stats_file_unmap(history_file);
> stats_file_unmap(temp_file);
>
> - TFR(close(temp_file->fd));
> + (void)TFR(close(temp_file->fd));
>
> unlink(history_file->name);
>
> @@ -629,7 +629,7 @@ static int stats_file_close_swap(struct stats_file
> *history_file,
>
> unlink(temp_file->name);
>
> - TFR(close(history_file->fd));
> + (void)TFR(close(history_file->fd));
>
> stats_file_cleanup(history_file);
> stats_file_cleanup(temp_file);
> diff --git a/tools/iptables-test.c b/tools/iptables-test.c
> index 2985788..9d74d45 100644
> --- a/tools/iptables-test.c
> +++ b/tools/iptables-test.c
> @@ -1151,7 +1151,7 @@ static void connman_iptables_dump(struct
> connman_iptables *table)
>
> connman_iptables_dump_hook(table);
>
> - ENTRY_ITERATE(table->blob_entries->entrytable,
> + (void)ENTRY_ITERATE(table->blob_entries->entrytable,
> table->blob_entries->size,
> connman_iptables_dump_entry, table);
>
> @@ -1279,7 +1279,7 @@ static struct connman_iptables
> *connman_iptables_init(const char *table_name)
> memcpy(table->hook_entry, table->info->hook_entry,
> sizeof(table->info->hook_entry));
>
> - ENTRY_ITERATE(table->blob_entries->entrytable,
> + (void)ENTRY_ITERATE(table->blob_entries->entrytable,
> table->blob_entries->size,
> add_entry, table);
>
> diff --git a/tools/stats-tool.c b/tools/stats-tool.c
> index 13e9e98..9a8dd78 100644
> --- a/tools/stats-tool.c
> +++ b/tools/stats-tool.c
> @@ -791,7 +791,7 @@ static void swap_and_close_files(struct stats_file
> *history_file,
> munmap(history_file->addr, history_file->len);
> munmap(temp_file->addr, temp_file->len);
>
> - TFR(close(temp_file->fd));
> + (void)TFR(close(temp_file->fd));
>
> unlink(history_file->name);
>
> @@ -799,7 +799,7 @@ static void swap_and_close_files(struct stats_file
> *history_file,
> return;
>
> unlink(temp_file->name);
> - TFR(close(history_file->fd));
> + (void)TFR(close(history_file->fd));
> }
>
> static void history_file_update(struct stats_file *data_file,
Regards
Marcel
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
