Hi Jukka,

> v5:
> - patch order changed
> - new patch (#4) that replaces dhcp_add_simple_option() with
>   three variants for different data sizes (uint8, uint16 and uint32)
> 
> v4:
> - remove inclusion guard from header file (#1)
> - really remove unneccesary cast in client.c (#2)
> - use host byte order internally (#2)
> - changed option_u8 to option (#2)
> - remove obsolete function (#3)
> 
> v3:
> - use unalignment macros from Bluez (#1)
> - remove unnecessary cast in client.c (#2)
> - add comment in client.c (#2)
> 
> Patch #1 remove obsolete function
> 
> Patch #2 creates put|get_unaligned and get_[b|l]e* macros which
> can convert between big-endian or little-endian values.
> 
> Patch #3 adds the alignment macros into gdhcp code.
> 
> Patch #4 replaces option setting function (dhcp_add_simple_option)
> with three variants for setting uint8, uint16 and uint32 values.

I applied these 4 patches.

> Patch #5 downgrades cast-align and unused-value errors into warnings
> so that we can compile connman using clang. Eventually we should either
> change connman code or do some voodoo magic with clang and enable
> the errors back.

I hate this one actually. We need to figure out on how we can do that
better.

Regards

Marcel


_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to