Hi,
On Thu, 2012-10-04 at 12:56 +0300, Jukka Rissanen wrote:
> Because the vpnd Create() in manager API only creates and does
> not connect the vpn, we must do the connect part after the
> vpn is created. This requires a callback which is called when
> the connection is established. Eventually this patch becomes
> obsolete because the CreateProvider() connman API is deprecated.
> ---
> include/provider.h | 4 +-
> plugins/vpn.c | 172
> +++++++++++++++++++++++++++++++++++++++--------------
> src/provider.c | 42 +++++++++++--
> 3 files changed, 169 insertions(+), 49 deletions(-)
>
> diff --git a/include/provider.h b/include/provider.h
> index 548bd61..254af94 100644
> --- a/include/provider.h
> +++ b/include/provider.h
> @@ -112,6 +112,8 @@ int connman_provider_append_route(struct
> connman_provider *provider,
>
> const char *connman_provider_get_driver_name(struct connman_provider
> *provider);
> const char *connman_provider_get_save_group(struct connman_provider
> *provider);
> +typedef void (* connection_ready_cb) (DBusMessage *msg, int
> error_code,
> + const char *path);
Would it be better to have a void *user_data instead of the const char
*path here? It'd be more in sync with other parts in ConnMan.
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman