Actually:
This check does not make sense at all. We want to insert the new
rule always on the first position, that means the chain_head
points to the 'old' entry.
Wait no: this is only true when you insert a rule, not when you append one.
And finally - my mistake because I should have reviewed it properly - I
am not happy with your: __connman_iptables_append()
It does not append, it inserts. It reminds me why I was maintaining in
// the iptables-test.c tool.
It's annoying but it's useful to find such regressions.
Hopefully iptables api in ConnMan is almost not used, so it does not
affect anything... yet :)
Tomasz
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
