Hi Patrik,

On 03/07/2013 03:27 PM, Patrik Flykt wrote:
On Thu, 2013-03-07 at 14:35 +0100, Daniel Wagner wrote:
From: Daniel Wagner <[email protected]>

We need to see a bit more in detail what happens when
CONNMAN_IPTABLES_DEBUG is not set, for example the removing/flushing
during bootup.

You probably meant when the variable is set here?

Hmm, kind of obfuscated message. I try to rephrase it.

"When normal debugging mode is enabled (that means just a plain
'-d' is given and no CONNMAN_IPTABLES_DEBUG given) then we should
be able to follow what's happening in iptables.c. With adding additional DBG() at the entry points to the code we see what's going on without detailed debugging enabled."

Does this help?

Also remove the DBG() from parse_rule_spec() because all callers
already have a DBG(). So not much additional information here.
---
  src/iptables.c | 21 +++++++++++++++++----
  1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/src/iptables.c b/src/iptables.c
index 1db87ac..6d8168b 100644
--- a/src/iptables.c
+++ b/src/iptables.c
@@ -160,6 +160,7 @@ struct connman_iptables_entry {
  };

  struct connman_iptables {
+       char *name;
        int ipt_sock;

Will 'name' be used for anything else than debugging?

Yes.

cheers,
daniel

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to