Hi Daniel,
I really should spend more time in explaining stuff in the cover letter.
These patches are kind of left overs from the bug fixing session and
not really necessary if you think in 'does it fix a bug' or 'it's a
new feature'. These patches are just plain maintaining work which
improve the structure of the code and should help to the next reader
not to spend weeks going over the code again and again which I did.
It's like that in many parts in connman, and the code has not much to do
here: usually it's because the domain it's touching is really complex.
And the coder will have to make effort to understand the domain to
understand the code.
In iptables.c the complexity comes from xtables, any rewrite won't fix
it. And you know that.
Talking about next reader in this specific context is not really an
argument.
In most of your rewrite in later patches, the comments your added are
the real worthy part, not the code rewrite itself.
I understand you spend much time on iptables.c to understand it, I went
through the same hassle. But refactoring is a trap, especially there.
Moreover it can introduce regressions.
I agree with patches 1,2,3,4,5,6,7. The rest it too much change for -
objectively - no real benefit. Besides the comments.
Cheers,
Tomasz
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
