On 08.03.2013 11:27, Patrik Flykt wrote:
On Tue, 2013-03-05 at 16:06 +0200, Jukka Rissanen wrote:
The immutable settings are those that are read from .config file.
---
  vpn/vpn-provider.c | 29 ++++++++++++++++++++++++-----
  vpn/vpn.h          |  2 ++
  2 files changed, 26 insertions(+), 5 deletions(-)

diff --git a/vpn/vpn-provider.c b/vpn/vpn-provider.c
index 0336636..abef7cd 100644
--- a/vpn/vpn-provider.c
+++ b/vpn/vpn-provider.c
@@ -53,6 +53,7 @@ struct vpn_route {

  struct vpn_setting {
        gboolean hide_value;
+       gboolean immutable;
        char *value;
  };

Would it be easier just to block the whole net.connman.vpn.Connection
API and a few parts of net.connman.vpn.Manager API instead of examining
each value separately?


There are variables that are set by vpn plugins. If we prevent the vpn plugins from setting certain variables, the vpn plugins cannot function properly.

What this means in practice is that:
- if there is a .config file for vpn, then its values are read and they are marked immutable - from dbus, user cannot set any value of the provisioned vpn via .config file - vpn plugin can set those vpn variables that are not set by the .config file
For this to work, the setting struct contains the immutable flag.


Cheers,
Jukka

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to