On 03/15/2013 01:50 PM, Daniel Wagner wrote:
+static int firewall_disable(GList *rules)
+{
+       struct fw_rule *rule;
+       GList *list;
+       int err;
+
+       for (list = rules; list != NULL; list = g_list_previous(list)) {
+               rule = list->data;
+
+               err = __connman_iptables_delete(rule->table,
+                                               rule->chain,
+                                               rule->rule_spec);
+               if (err < 0) {
+                       connman_error("Cannot remove previously installed "
+                               "iptables rules: %s", strerror(-err));
+                       break;
+               }
+
+               err = __connman_iptables_commit(rule->table);
+               if (err < 0) {
+                       connman_error("Cannot remove previously installed "
+                               "iptables rules: %s", strerror(-err));
+                       break;
+               }
+       }
+
+       return err;
+}

err is not initialized in all cases. I have an updated for this one.
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to