On Tue, Apr 23, 2013 at 3:51 PM, Marcel Holtmann <[email protected]> wrote:
> Hi Jukka,
>
>> ---
>> src/main.conf | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/src/main.conf b/src/main.conf
>> index a0608d4..7b155af 100644
>> --- a/src/main.conf
>> +++ b/src/main.conf
>> @@ -85,3 +85,8 @@
>> # This is a dangerous setting so the default value is false.
>> # Do not activate this unless you really know what you are doing.
>> # AllowEthernetTethering = false
>> +
>> +# Remeber technology tethering status and activate tethering when
>> +# ConnMan starts if the tethering was active when ConnMan was stopped.
>> +# Default value is false.
>> +# StartTetheringAutomatically = false
>
> this is pretty bad naming. Don't we want something like 
> RememberTetheringMode, PersistentTetheringMode or similar. Or something like 
> AlwaysEnableTethering or similar.
>
> No matter what would be the final name, the semantics of these two are 
> different. One would enable Tethering all the time, and the other would just 
> remember the setting that got configured.

I think it makes more sense to remember the setting than make it a
"always enable option".  For example I have a device at home that I
want tethering enabled for how long I set it to be enabled (no matter
if the device crashed, restarted, etc). I certainly don't want to set
it in the config file every time I want to switch it on or off.

Lucas De Marchi
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to