From: Daniel Wagner <[email protected]> v1 - use sizeof(ifr.ifr_name) instead of IFNAMSIZ everywhere - set need_split only once - s/coverty/coverity/ - call close() after storing error code
Note that i did not update patch 'ipv4ll: Initialize socket variable' because the rest of the of the file uses memset and not static initializers. v0 - initial version Original coverletter Hi, I have run coverty over our code base and guess what, it found bugs :) This here is the first batch of fixes which are reported as 'high impact'. If someone wants also access to the reporty, just create an account on http://scan.coverity.com/ and request access permission for ConnMan. cheers, daniel Daniel Wagner (12): service: Enable splited routing dbus: Initialize uid for error path inet: Close socket when leaving function early core: Set device name with null termination inet: Initialize flags to 0 rtnl: Do not access variables out of scope timezone: Null terminate pathname log: Do not access array out of bounds ipv4ll: Initialize socket variable wifi: Do not access unitialized timestamp dnsproxy-test: Close socket in error path tap-test: Set device name with null termination gdhcp/ipv4ll.c | 3 +++ plugins/wifi.c | 14 +++++++------- src/6to4.c | 8 ++++---- src/dbus.c | 2 +- src/inet.c | 17 +++++++++++------ src/log.c | 2 +- src/rtnl.c | 8 +++----- src/service.c | 2 +- src/timezone.c | 2 +- tools/dnsproxy-test.c | 1 + tools/tap-test.c | 4 ++-- 11 files changed, 35 insertions(+), 28 deletions(-) -- 1.8.4.474.g128a96c _______________________________________________ connman mailing list [email protected] https://lists.connman.net/mailman/listinfo/connman
