Hi,

On Thu, 2013-11-28 at 09:38 +0100, Daniel Wagner wrote:
> From: Daniel Wagner <[email protected]>
> 
> The data pointer is garanteed to be no NULL. The check
> happens on the caller side of interface_scan_result.

Nitpick: the commit message is slightly off. The NULL check is
unnecessary, but if data were to be NULL, there would have been a crash
already.

> ---
>  gsupplicant/supplicant.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
> index 06ab20e..438d7f6 100644
> --- a/gsupplicant/supplicant.c
> +++ b/gsupplicant/supplicant.c
> @@ -2723,7 +2723,7 @@ static void interface_scan_result(const char *error,
>               data->interface->scan_data = data->user_data;
>       }
>  
> -     if (data && data->scan_params)
> +     if (data->scan_params)
>               g_supplicant_free_scan_params(data->scan_params);
>  
>       dbus_free(data);

Cheers,

        Patrik


_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman

Reply via email to