Hi Patrik,

+       if (!global_firewall) {
Let's not poke on global_firewall outside of init_firewall(). Let's fix
this in init_firewall() instead, as global_firewall is internal to that
function. init_firewall() has a bug as it does not check if
global_firewall is set or not and sets it unconditionally every time -
and looses memory when doing so.

Indeed, will fix this too.

>+           err = init_firewall();
>+           if (!err)
Shouldn't this be if '(err < 0)' ?

It should yes...

Tomasz
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman

Reply via email to