From: Daniel Wagner <[email protected]>

The NULL check is unnecessary, because the caller provides a valid
pointer. If data were to be NULL, there would have been a crash
already because we already derefence it a few lines above.
---
 gsupplicant/supplicant.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 649e514..7074c02 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -2798,7 +2798,7 @@ static void interface_scan_result(const char *error,
                data->interface->scan_data = data->user_data;
        }
 
-       if (data && data->scan_params)
+       if (data->scan_params)
                g_supplicant_free_scan_params(data->scan_params);
 
        dbus_free(data);
@@ -2999,7 +2999,7 @@ static void interface_autoscan_result(const char *error,
 
        g_free(data->path);
 
-       if (data && data->callback)
+       if (data->callback)
                data->callback(err, data->interface, data->user_data);
 
        dbus_free(data);
-- 
1.8.4.474.g128a96c

_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman

Reply via email to