On Tue, 2013-12-03 at 09:20 +0000, Potrola, MateuszX wrote:
> Hi,
>
> Updated commit message and lines < 80 characters in width
>
> Regards,
> Mateusz Polrola
This part will show up as your commit message, which was not what was
intended. The subject line is enough for a short patch like this. You
can add any additional comments between the '---' line and the stats.
> ---
> src/service.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/src/service.c b/src/service.c
> index 5c8f9d0..3582ec9 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -5369,10 +5369,6 @@ static int service_indicate_state(struct
> connman_service *service)
> domain_changed(service);
> proxy_changed(service);
> - if (old_state == CONNMAN_SERVICE_STATE_READY ||
> - old_state ==
> CONNMAN_SERVICE_STATE_ONLINE)
> -
> __connman_notifier_disconnect(service->type);
> -
> /*
> * Previous services which are connected and
> which states
> * are set to online should reset relevantly
> ipconfig_state
> @@ -5384,9 +5380,6 @@ static int service_indicate_state(struct
> connman_service *service)
> }
> if (new_state == CONNMAN_SERVICE_STATE_FAILURE) {
> - if (old_state == CONNMAN_SERVICE_STATE_READY ||
> - old_state ==
> CONNMAN_SERVICE_STATE_ONLINE)
> -
> __connman_notifier_disconnect(service->type);
> if (service->userconnect &&
>
> connman_agent_report_error(service, service->path,
> @@ -5406,6 +5399,15 @@ static int service_indicate_state(struct
> connman_service *service)
> __connman_connection_update_gateway();
> + if((old_state == CONNMAN_SERVICE_STATE_ONLINE &&
> + new_state != CONNMAN_SERVICE_STATE_READY) ||
> + (old_state == CONNMAN_SERVICE_STATE_READY &&
> + new_state != CONNMAN_SERVICE_STATE_ONLINE))
> + {
This open curly parenthesis on the previous line, please. Check also the
space between if and '(' as well as indentation in the if statement,
examples above in the same file.
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
