Hi Patrik,
2014/1/7 Patrik Flykt <[email protected]> > > Hi, > > On Mon, 2014-01-06 at 16:06 +0800, Chengyi Zhao wrote: > > > Yes, user shouldn't connect a WEP encrypted WiFi network, and this is > > a ConnMan's design practice, it is very good, but the downstream > > product need to support the user case which user connects a WEP > > encrypted AP. > > > > So I will modify this patch, add a new flag to request the WEP > > passphrase, and only merge it to the downstream product. > > I don't see how a flag would help you with anything here. Please do not > add such unreviewed code to any downstream product, I have severe doubts > of it working in the first place > > AFAIK the only way to detect an invalid WEP key is the following: > > >> The approximately only way of detecting an invalid WEP key is to > >> notice that traffic for this SSID cannot be decrypted. If this > >> persists for some time, it is very likely that the WEP passphrase is > >> incorrect. > > Please have a look at the problem from that end first, Thanks, I agree with you. > or change the UI > to always remove the WEP network instead of disconnecting it when > "Disconnect" functionality is requested from the UI by the user. > I don't think UI designers will agree with this point. Cheers, Chengyi _______________________________________________ connman mailing list [email protected] https://lists.connman.net/mailman/listinfo/connman
