On Thu, 2014-03-27 at 10:53 +0800, [email protected] wrote:
> From: Zhang zhengguang <[email protected]>
>
> In bluez 4.x plugin, when bluetooth tethering is enabled,
> set_tethering() returns 0, while in bluez 5.x plugin,
> it returns -EINPROGRESS, which is not compatiable for
> ConnMan to handle both of them, this patch makes bluez
> 5.x tethering enable logic consistent with bluez 4.x.
> ---
> plugins/bluetooth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c
> index ae3ac60..6bea834 100644
> --- a/plugins/bluetooth.c
> +++ b/plugins/bluetooth.c
> @@ -865,7 +865,7 @@ static int bluetooth_tech_set_tethering(struct
> connman_technology *technology,
> if (i == 0)
> return -ENODEV;
>
> - return -EINPROGRESS;
> + return 0;
NAK. This is not a problem and exactly what is intended. Bluetooth will
take a D-Bus message round-trip time to conclude whether tethering is
enabled or not, meanwhile it better signal -EINPROGRESS for consistency.
If bluetooth_legacy.c is not doing the same, it is the one in need of
more fixing. I don't see bluetooth_legacy having any issues in this
respect, though.
Is there some problem with ConnMan handling this return value?
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
