Hi Eric, On 28 March 2014 18:00, Eric BOUXIROT <[email protected]> wrote: >> i will send the patch for discussion in few minutes. (don't know connman >> too much to know if there is a side effect) > > > here my patch > > diff -uprN a/plugins/ofono.c b/plugins/ofono.c > --- a/plugins/ofono.c 2014-03-28 16:48:01.000000000 +0100 > +++ b/plugins/ofono.c 2014-03-28 14:40:11.000000000 +0100 > @@ -265,8 +265,9 @@ static void set_connected(struct modem_d > DBG("%s", modem->path); > > index = modem->context->index; > - > - if (index < 0 || !modem->context->ipv4_address) { > + method = modem->context->ipv4_method; > + > + if (index < 0 || (!modem->context->ipv4_address && method == > CONNMAN_IPCONFIG_METHOD_FIXED)) { > connman_error("Invalid index and/or address"); > return; > } > @@ -275,7 +276,6 @@ static void set_connected(struct modem_d > if (!service) > return; > > - method = modem->context->ipv4_method; > if (method == CONNMAN_IPCONFIG_METHOD_FIXED || > method == CONNMAN_IPCONFIG_METHOD_DHCP) { > connman_service_create_ip4config(service, index); > > do you mean i'm right with this ?
Yes, your patch looks very sane to me. Cheers, Jukka _______________________________________________ connman mailing list [email protected] https://lists.connman.net/mailman/listinfo/connman
