Hi Patrik and list
> > > On Thu, 2014-04-03 at 15:35 +0200, Tim Sander wrote:
> > > > I currently have a connman 1.22 set up with time TimeUpdates set to
> > > > manual. This is due to the fact that i use ntpd for time
> > > > synchronisation due to the better accuracy.
>
> If there is anything in the accuracy calculation itself, please send
> patches. Currently we're fine with SNTP using one NTP server at a time,
> if it's this part that causes most of the inaccuracy there's
> unfortunately not much that can be done.
Well concerning the timeoffset discovered was an error in the test setup due to
wrong cableing. Unfortunalty the SNTP protocol was not precise enough in a
heavily
loaded network compared to ntpd.
<SNIP>
> This function is called from multiple places, not only when updating
> service properties. If this function returns something non-NULL - which
> it does after the above change - the other parts of the code will make
> ConnMan believe it is to handle NTP...
<SNIP>
> This part prevents only DNS lookups, if the timeservers are specified
> using IP addresses, they are used and ConnMan happily does the NTP part
> itself. DHCP always gives NTP servers as IP addresses...
Thanks for the heads up. I have another patch just for reference:
--- connman-1.22/src/timeserver.c.orig 2014-04-10 09:08:41.637937810 +0200
+++ connman-1.22/src/timeserver.c 2014-04-10 09:13:13.800070946 +0200
@@ -235,7 +235,7 @@
ts = __connman_timeserver_get_all(__connman_service_get_default());
- if (!ts) {
+ if (!ts || __connman_clock_timeupdates() == TIME_UPDATES_MANUAL) {
DBG("timeservers disabled");
return TRUE;
@@ -274,6 +274,9 @@
static void ts_recheck_enable(void)
{
+ if(__connman_clock_timeupdates() == TIME_UPDATES_MANUAL)
+ return;
+
if (ts_recheck_id > 0)
return;
@@ -317,8 +320,8 @@
__connman_service_timeserver_changed(service, ts_list);
- if (!ts_list) {
- DBG("No timeservers set.");
+ if (!ts_list || __connman_clock_timeupdates() == TIME_UPDATES_MANUAL) {
+ DBG("No timeservers set or disabled.");
return 0;
}
It would be nevertheless nice to have the information connman posseses
available at
the dbus. Like the DHCP information or ntp round trip times. But as far as i
remember
you don't want these due to maintenance burden. Alas.
Best regards
Tim
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
