Hi,
As noticed from Eduardo's patch set, device->devname is in use in exactly
one place in the WiFi plugin. For simplicity, it'd make sense to remove
this attribute thereby cleaning up the code. This patch set is an RFC
only, let's see what we want to do in the end.
Patch 01 removes the only known user of device->interface which enables
the patch 03 to eliminate the attribute completely. At the same time
remove also device->devname in patch 02, it wasn't used at all.
Now the next problem that becomes evident after this patch set is the
use of the connman_inet_ifname/connman_inet_ifindex function pair. Both
of them use an ioctl to get the desired name/index, information which
we already have with rtnl. So the next task would be to properly follow
rtnl newlink and pick up the interface names as they appear and turn over
those two functions to connman_device_ifname/connman_device_ifindex and
using the info from rtnl instead. Either with or without a device struct
as argument.
Any takers...?
Cheers,
Patrik
Patrik Flykt (3):
wifi: Don't fetch interface name from device structure
device: Remove unused device->devname
device: Don't store interface name in device struct
include/device.h | 2 --
plugins/wifi.c | 9 +++++++--
src/device.c | 31 -------------------------------
3 files changed, 7 insertions(+), 35 deletions(-)
--
1.9.1
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
