Hi Pasi,
Minor comments,
Sometimes captive portal system might return these status codes
when continuing with g_web_request_get after the initial 302 status
code. Let the browser handle these cases.
000 is seen with http://www.hotspotsystem.com/
505 is seen with http://nextmesh.net/
Special thanks to Lorn Potter.
Signed-off-by: Pasi Sjöholm <[email protected]>
We don't use signed-off in connman ;)
---
src/wispr.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/src/wispr.c b/src/wispr.c
index dcce93c..4b60c69 100644
--- a/src/wispr.c
+++ b/src/wispr.c
@@ -711,6 +711,12 @@ static bool wispr_portal_web_result(GWebResult *result,
gpointer user_data)
DBG("status: %03u", status);
switch (status) {
+ case 000:
+ DBG("Status code 000 (proxy?), handling over to the browser");
No need of this debug message (the status is already printed above)
+ __connman_agent_request_browser(wp_context->service,
+ wispr_portal_browser_reply_cb,
+ wp_context->status_url, wp_context);
+ break;
case 200:
if (wp_context->wispr_msg.message_type >= 0)
break;
@@ -755,6 +761,12 @@ static bool wispr_portal_web_result(GWebResult *result,
gpointer user_data)
}
break;
+ case 505:
+ DBG("HTTP version not supported, hand over to the browser");
Same here.
Anyway, though handling this status 505 like you propose is fine, it
would be great
to know what/where/how made this status to fix gweb then (if there is
something to be fixed there).
+ __connman_agent_request_browser(wp_context->service,
+ wispr_portal_browser_reply_cb,
+ wp_context->status_url, wp_context);
+ break;
default:
break;
}
Tomasz
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
