Hi Alexandru,
On 07/02/2014 11:32 AM, Alexandru Costache wrote:
> src/dhcp.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/src/dhcp.c b/src/dhcp.c
> index c717f84..7048731 100644
> --- a/src/dhcp.c
> +++ b/src/dhcp.c
> @@ -70,6 +70,8 @@ static void dhcp_free(struct connman_dhcp *dhcp)
> g_free(dhcp);
> }
>
> +static void ipv4ll_stop_client(struct connman_dhcp *dhcp);
> +
Oopps I overlooked this one in the last review. We try to avoid to have
forward decleration unless really needed. I think you can move
ipv4ll_stop_client() up (there isn't any dependency to functions inside
the file).
> /**
> * dhcp_invalidate: Invalidate an existing DHCP lease
> * @dhcp: pointer to the DHCP lease to invalidate.
> @@ -131,6 +133,14 @@ static void dhcp_invalidate(struct connman_dhcp *dhcp,
> bool callback)
> __connman_ipconfig_set_gateway(ipconfig, NULL);
> __connman_ipconfig_set_prefixlen(ipconfig, 0);
>
> + if (dhcp->timeout > 0) {
> + g_source_remove(dhcp->timeout);
> + dhcp->timeout = 0;
> + }
> +
> + if (ipv4ll_running)
> + ipv4ll_stop_client(dhcp);
> +
> if (dhcp->callback && callback)
> dhcp->callback(dhcp->network, false, NULL);
> }
> -- 1.8.1.4
>
Thanks,
Daniel
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
