Hi,

The commit fa7141ae55aad fixed the dns queries without
domain part. Unfortunately there was a bug in that commit
which is now fixed by patch 1. The labels in the dns query
were uncompressed which changes the label length bytes
into dots. These dots need to be converted back to
length bytes but that was not done. This is only seen
if the user is querying without domain name part.

Patch 2 fixes a nastier issue. The old code stripped
the domain part away from the dns question part but left
the FQDN into dns answers. This works ok for glibc users
of getaddrinfo() (like traceroute) but fails for
gethostbyname() users (like ping) which does some extra
checks and expects that answers contain only host part
without domain name.


Thanks to Pasi Sjöholm for reporting this.

Cheers,
Jukka


Jukka Rissanen (2):
  dnsproxy: Uncompressed label was not set to internal format
  dnsproxy: Remove domain part from answers

 src/dnsproxy.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 69 insertions(+), 16 deletions(-)

-- 
1.8.3.1

_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman

Reply via email to