Hi,
>
> From: Chengyi Zhao <[email protected]>
>
> When reconnected a same service which it has already been
> either connected or connecting before, this service doesn't
> need to be disconnected.
> ---
> src/service.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/service.c b/src/service.c
> index 9406bc3..2421215 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -3968,6 +3968,9 @@ static DBusMessage *connect_service(DBusConnection
> *conn,
> if (!is_connecting(temp) && !is_connected(temp))
> break;
>
> + if (g_strcmp0(service->path, temp->path) == 0)
> + break;
> +
I'd like to explain why committed this path.
Do the following operations before applying this patch:
root:/usr/lib/connman/test> ./test-connman connect
wifi_00dbdf140abe_54502d4c494e4b5f343736383741_managed_psk
root:/usr/lib/connman/test> ./test-connman connect
wifi_00dbdf140abe_54502d4c494e4b5f343736383741_managed_psk
net.connman.Error.Failed: Input/Output Error
I think this is a issue that user gets the IO error and network will be
diconnected when reconnected
the same service.
Do the following operations after applying this patch:
root:/usr/lib/connman/test> ./test-connman connect
wifi_00dbdf140abe_54502d4c494e4b5f343736383741_managed_psk
root:/usr/lib/connman/test> ./test-connman connect
wifi_00dbdf140abe_54502d4c494e4b5f343736383741_managed_psk
net.connman.Error.AlreadyConnected: Already connected
Perhaps the better patch will fix this issue, please check.
Thanks,
Chengyi
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
