On 01/09/14 16:23, Patrik Flykt wrote:
Hi,
On Mon, 2014-09-01 at 15:52 +0300, Slava Monich wrote:
On 01/09/14 13:16, Patrik Flykt wrote:
On Sat, 2014-08-30 at 15:15 +0300, Slava Monich wrote:
This is for pacrunner.
More motivation in here why this patch is good, please.
Cheers,
Patrik
A thread may either be/joinable/ or/detached/. If a thread is
joinable, then another thread can callpthread_join(3)
<http://man7.org/linux/man-pages/man3/pthread_join.3.html> to wait for
the thread to terminate and fetch its exit status. Only when a
terminated joinable thread has been joined are the last of its
resources released back to the system. When a detached thread
terminates, its resources are automatically released back to the
system: it is not possible to join with the thread in order to obtain
its exit status. Making a thread detached is useful for some types
of daemon threads whose exit status the application does not need to
care about. By default, a new thread is created in a joinable state,
unless/attr/ was set to create the thread in a detached state (using
pthread_attr_setdetachstate(3)
<http://man7.org/linux/man-pages/man3/pthread_attr_setdetachstate.3.html>).
No, I'm not looking for a man page here. A proper commit message on what
is fixed will do fine.
The subject line is fine summary, but "This is for pacrunner" is not a
proper commit message. I was looking for the body of the commit message
saying something like "Unless the threads are detached, .... will be
lost on ....". Or something suitable. So that when the next person looks
at the changed lines and checks the individual commit, he goes: "Ah, of
course!"
Of course threads that are never joined have to be detached. I really
don't know what to add. I thought (and still think) that the subject
line says it all.
"This is for pacrunner" just means "sorry I couldn't find a dedicated
mailing list for pacrunner but I hope this patch will reach the right
people if I send it to [email protected]".
Regards,
-Slava
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
