Hi,
Patch 1/2 removes 'Failure' saving and loading to disk. Loading a
'Failure' property has only forced IPv4/v6 states to failure for
non-favorite services and always set service error reason. Enforcing
the IPv4/v6 state like that is a bug. In normal autoconnect cases the
non-favorite status of the service has caused the service to be ignored,
and setting the error causes troubles only on connecting if the reason
for failure was invalid-key. In all cases the key is correct either
after connecting to the service after the firs time or if supplied by
a provisioning file, recording an unfortunate failure during connection
that wpa_s interpreted as an invalid key simply caused a properly
configured wifi service from going into failure state immediately
without even trying to connect.
The second patch removes an extra check for an invalid key. The invalid
key is detected by the wifi plugin, which notifies network.c which then
calls __connman_service_indicate_error(). This last function removes the
passphrase, which is checked a few lines before the ones removed by
this patch... So the possibility of reporting -ENOKEY due to
service->error was limited to the cases where the service error was read
from file. This extra check can therefore be removed.
These two should fix the bug found by Thiemo van Engelen.
Cheers,
Patrik
Patrik Flykt (2):
service: Don't save or load reason for failure
service: When connecting, ignore previous invalid key errors
src/service.c | 40 +++++-----------------------------------
1 file changed, 5 insertions(+), 35 deletions(-)
--
2.1.1
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
