Hi Tomasz, > No because the autoscan is not a user triggered scan, the fact it's > reset after a user triggered scan is nominal, but we don't want to > relate the DBus pending call to it. The end result is that he will get > all the results properly through Manager.ServicesChanged() signal, after > his scan and after all autoscan events if those brings updates. > >> I agree that scanning known networks first is a good feature, so I am >> a bit concerned that sending a patch like the hunk above will make >> finding known networks slower. > > Known networks will be eventually found in such full scan so no worry. > When connected, there won't be any scan ran unless the user asks for one. > At this point doing only a full scan is the best imo.
Agreed that watching for ServicesChanged() will be required regardless and that autoscan will get around to scanning the remaining channels after the dbus pending call finishes, so this is one reasonable way to meet my specific needs, so I will drop the dbus api change. > And you patch does not affect the nominal behavior when not connected > (first a known networks scan, then a full scan via autoscan, etc...) For a user-requested scan when disconnected, yes, it is still known networks first, then full scan. However, disconnect_callback() calls start_autoscan(), and that leads to a throw_wifi_scan() of all channels, not a scan for known networks. I think that is ok, or at least the subject of a separate patch. > Your patch is good to go, send it. Sent .. thanks for the review Jason _______________________________________________ connman mailing list [email protected] https://lists.connman.net/mailman/listinfo/connman
