On Tue, 2014-12-16 at 11:34 +0200, [email protected] wrote:
> From: Jarko Poutiainen <[email protected]>
>
> -Reset ipv4/6_method to CONNMAN_IPCONFIG_METHOD_UNKNOWN when
> protocol is set ip/ipv6/dual on ofono.
>
> -IPv6 configuration method is either CONNMAN_IPCONFIG_METHOD_FIXED
> (ipv6-pdp) or CONNMAN_IPCONFIG_METHOD_AUTO (SLAAC/DHCPv6,
> dual/ipv4v6-pdp).
>
> -When connection is set active, method needs to be set
> CONNMAN_IPCONFIG_METHOD_UNKNOWN so that no old configuration
> is used in case only ipv4/ipv6-configuration is set.
>
> -Nameservers need to also reset when new addresses are extracted
> so that they are not reused when pdp-protocol changes from ipv6
> to dual/ipv4v6.
>
> Patch by Jarko Poutiainen <[email protected]> and
> Pasi Sjöholm <[email protected]>
NACK.
As your commit message already reveals, there are too many things going
on at the same time in this patch. The same thing is visible also from
the code. Please split it up into more parts.
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
