Hi,
>> extract_ipv6_settings(&value, modem->context);
>> + } else if (g_str_equal(key, "Protocol")) {
>> + DBG("%s Protocol", modem->path);
>> +
>> + modem->context->ipv4_method = CONNMAN_IPCONFIG_METHOD_UNKNOWN;
>> + modem->context->ipv6_method = CONNMAN_IPCONFIG_METHOD_UNKNOWN;
>> } else if (g_str_equal(key, "Active")) {
>Why isn't the value of the oFono 'Protocol' property considered above?
1) Protocol can be only set on ofono when context is not active (connected).
2) We just want to reset the ipv4/6_method to UNKNOWN-state so that both will
have to be reconsidered next time when getting online as we do not want to
reuse the old configuration from connman side (ip-addres, gateway..) when
running set_connected(). E.g. connman setting up (saved) fixed ipv6-address
while doing ipv4-only.
3) I don't see any point doing unnecessary comparisation like:
if (ip) modem->context->ipv6_method = CONNMAN_IPCONFIG_METHOD_UNKNOWN;
else if (ipv6) modem->context->ipv4_method = CONNMAN_IPCONFIG_METHOD_UNKNOWN;
when we are going to setup the correct method in extract_ipv4_settings and
extract_ipv6_settings but as those are only run when correct message is
received therefore we need to reset the methods beforehand.
Br,
Pasi
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
