On Wed, 2015-01-14 at 19:40 -0800, Naveen Singh wrote:
> Do you guys think if the following make sense:
>
> diff --git a/plugins/wifi.c b/plugins/wifi.c
> index 97f7144..863109d 100644
> --- a/plugins/wifi.c
> +++ b/plugins/wifi.c
> @@ -2207,7 +2207,7 @@ static int network_connect(struct connman_network
> *network)
> ret = g_supplicant_interface_connect(interface, ssid,
> connect_callback, network);
>
> - if (ret < 0) {
> + if (ret < 0 && ret != -EINPROGRESS) {
> connman_network_unref(network);
> }
This would make sense, except that the same code in upstream looks like
this:
static int network_connect(struct connman_network *network)
...
if (wifi->disconnecting) {
wifi->pending_network = network;
g_free(ssid);
} else {
wifi->network = connman_network_ref(network);
wifi->retries = 0;
return g_supplicant_interface_connect(interface, ssid,
connect_callback, network);
}
return -EINPROGRESS;
}
You are obviously working on a non-upstream version of ConnMan.
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
