On Tue, 2015-01-13 at 15:05 -0500, Hannu Mallat wrote:
> Reworked patch 2 and 3 based on review comments; did not touch patch 6
> as the channel variable is referenced in send_request(). Getting rid
> of that reference would require adding channel as a parameter and
> changing all the callers, which is probably more work than it's worth.
>
> As I had previously sent v2 for patch 4, sending this set as v3.
Applied patches 1, 2 and 5-9.
Patch 3/9 constantly crashes for me on startup. For patch 4/9 it looks
to me as a better option is to always call interface_remove_result().
That is if someone later changes the internal callback to do other
things, that someone does not need to remember a particular special case
where it is not called.
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
