Sometimes wpa_supplicant reports BSS signal strength as zero or does not
send the BSS 'Signal' property on a newly discovered BSS at all.
As all other signal strength values are reported as negative values, a
value of zero will always be the greater than any later update with the
signal value locked at zero. This in turn translates into an eternal wifi
service signal strength of 100.
Fix this by using -90 as a reasonable value for a BSS with unknown signal
strength.
Reported by Thomas Green.
---
gsupplicant/supplicant.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 3bdf0dc..ef98894 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -44,6 +44,8 @@
#define IEEE80211_CAP_IBSS 0x0002
#define IEEE80211_CAP_PRIVACY 0x0010
+#define BSS_UNKNOWN_STRENGTH -90
+
static DBusConnection *connection;
static const GSupplicantCallbacks *callbacks_pointer;
@@ -1758,6 +1760,9 @@ static void bss_property(const char *key, DBusMessageIter
*iter,
dbus_message_iter_get_basic(iter, &signal);
bss->signal = signal;
+ if (!bss->signal)
+ bss->signal = BSS_UNKNOWN_STRENGTH;
+
} else if (g_strcmp0(key, "Level") == 0) {
dbus_int32_t level = 0;
@@ -1822,6 +1827,7 @@ static struct g_supplicant_bss
*interface_bss_added(DBusMessageIter *iter,
bss->interface = interface;
bss->path = g_strdup(path);
+ bss->signal = BSS_UNKNOWN_STRENGTH;
return bss;
}
@@ -1908,7 +1914,7 @@ static void interface_bss_removed(DBusMessageIter *iter,
void *user_data)
bss = g_hash_table_lookup(network->bss_table, path);
if (network->best_bss == bss) {
network->best_bss = NULL;
- network->signal = 0;
+ network->signal = BSS_UNKNOWN_STRENGTH;
}
g_hash_table_remove(bss_mapping, path);
--
2.1.4
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
