From: Pasi Sjöholm <[email protected]>

If timers are reset during __connman_resolver_redo_servers() they
will not have their timers set again at
connman_resolver_append_lifetime() because each entry without a
timer is a not RA initialized nameserver/domain search list.

Resetting the timers also causes the entry_list to grow by one or
more entries when the next RA with RDNSS/DNSSL is received as
connman_resolver_append_lifetime() will add the entries as new
because no matches will be found during the check.
---
 src/resolver.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/resolver.c b/src/resolver.c
index 01e7c0e..652f4fd 100644
--- a/src/resolver.c
+++ b/src/resolver.c
@@ -608,14 +608,6 @@ int __connman_resolver_redo_servers(int index)
                 */
                __connman_dnsproxy_remove(entry->index, entry->domain,
                                        entry->server);
-               /*
-                * Remove also the resolver timer for the old server entry.
-                * A new timer will be set for the new server entry
-                * when the next Router Advertisement message arrives
-                * with RDNSS/DNSSL settings.
-                */
-               g_source_remove(entry->timeout);
-               entry->timeout = 0;
 
                __connman_dnsproxy_append(entry->index, entry->domain,
                                        entry->server);
-- 
2.1.0

_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman

Reply via email to