Hi,
On Fri, 2015-02-27 at 14:14 +0200, Pasi Sjöholm wrote:
> this seems to work, and passwords are not getting flushed into thin air
> anymore.
>
> However there is a one problem still left in
> __connman_service_connect()-function. It has a call
> __connman_service_clear_error(service); at line 5973
> (https://git.kernel.org/cgit/network/connman/connman.git/tree/src/service.c#n5973)
> which then again has a call to set_error(service,
> CONNMAN_SERVICE_ERROR_UNKNOWN).
It was a while ago I did this patch, but now I can't figure out under
which exact circumstances the service error is set to unknown. Can you
try to elaborate a bit on that step?
> That will cause "err = service_connect(service);" to never return
> NOKEY-error.
> (https://git.kernel.org/cgit/network/connman/connman.git/tree/src/service.c#n5975)
>
>
> So, I guess set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN) needs to
> be removed from __connman_service_clear_error as well to keep the track
> of the error.
__connman_service_clear_error() does not have an explicit call to unset
the error, at least not after this patch...
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
