Hi,

On Mon, 2015-06-22 at 16:40 +0530, Maneesh Jain wrote:
> This patch is used to avoid any potential crash for below function.
> a. signal_peer_found
> b. signal_peer_changed
> ---
>  gsupplicant/supplicant.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
> index fb62a97..684e3d4 100755
> --- a/gsupplicant/supplicant.c
> +++ b/gsupplicant/supplicant.c
> @@ -2792,7 +2792,7 @@ static void signal_peer_found(const char *path, 
> DBusMessageIter *iter)
>       g_hash_table_insert(interface->peer_table, peer->path, peer);
>       g_hash_table_replace(peer_mapping, peer->path, interface);
>  
> -     property_data = dbus_malloc0(sizeof(struct peer_property_data));
> +     property_data = g_new0(struct peer_property_data,1);
>       property_data->peer = peer;
>  
>       dbus_message_iter_next(iter);
> @@ -2849,7 +2849,7 @@ static void signal_peer_changed(const char *path, 
> DBusMessageIter *iter)
>               return;
>       }
>  
> -     property_data = dbus_malloc0(sizeof(struct peer_property_data));
> +     property_data = g_new0(struct peer_property_data,1);
>       property_data->peer = peer;
>  
>       supplicant_dbus_property_foreach(iter, peer_property, property_data);

Now that the allocation was moved away from dbus_malloc0, is this free'd
properly and where?

Cheers,

        Patrik

_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman

Reply via email to