On Mon, 2015-06-29 at 16:19 +0530, Harish Jenny Kandiga Nagaraj wrote:
> Reason for giving this RFC patch was that it is not handled in
> add_or_replace_bss_to_network function in the following case.
> Failure in create_group or g_try_new0 .
That's actually good information for a commit message.
While the change might work for the specific instance you had in mind,
it does so in an implicit way which is not good. First, return an error
if the insertion failed in add_or_replace_bss_to_network() and second,
do something with that error value in the calling function. Then it will
be clear to all uses of the function what is going on.
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
https://lists.connman.net/mailman/listinfo/connman
