Hi, >But also scripts/connman.in should be modified to create the >needed symlink.
Are you saying that you would like to create the symlink as part of the packaging? I'm not sure this is necessarily a good idea, particularly when packaging with Debian. This means that connman would take 'ownership' of /etc/resolv.conf which is not necessarily a good idea. >Here I suppose the modifications are done via a connman.service.d/*.conf >systemd.unit files in order to eliminate source code patches for ConnMan >systemd service startup. We do not use a systemd dropin, we instead distribute our own systemd configuration. Part of this stems from the need for customisation at the moment, and also because at the time ConnMan had incorrect service dependencies. This was raised in #CM-683 by Simon Byrnand (OSMC) and was fixed in 1.30. Sam ________________________________________ From: connman <[email protected]> on behalf of Patrik Flykt <[email protected]> Sent: 15 September 2015 11:46 To: [email protected] Subject: Re: [PATCH] resolver: allow writing to /etc/resolv.conf to be disabled On Tue, 2015-09-15 at 07:15 +0000, Sam Nazarko wrote: > I am happy with this solution to write > to /var/run/connman/resolv.conf. I am happy to submit a patch for this > as well as a revised systemd service unit with an ExecStartPre= entry > to create the symlink before starting ConnMan. Please let me know if > you will accept this. systemd-tmpfiles looks like being the correct tool for this task. With this solution no additional variables are needed main.conf, which is a good thing. But also scripts/connman.in should be modified to create the needed symlink. The above scheme can fail if the system provides its own init scripts, so now would be the time to take notice, speak up and/or fix such init scripts. > Our current implementation actually calls a script before launching > ConnMan to run some sanity checks and evaluate whether we want > ConnMan's resolv.conf or not, but revising the systemd unit is > probably the best method to maintain immediate compatibility and > provide an entry point for other distributions to change this > behaviour. Here I suppose the modifications are done via a connman.service.d/*.conf systemd.unit files in order to eliminate source code patches for ConnMan systemd service startup. More comments, anyone? Patrik _______________________________________________ connman mailing list [email protected] https://lists.connman.net/mailman/listinfo/connman _______________________________________________ connman mailing list [email protected] https://lists.connman.net/mailman/listinfo/connman
