On Mon, 2015-10-05 at 16:05 +0530, Maneesh Jain wrote: > Signed-off-by: Maneesh Jain <maneesh.j...@samsung.com>
Please explain in the commit message *why* the client_id check is unnecessary. Quickly looking at the code doesn't immediately reveal the reasoning behind this check. No signed-off-bys either. > --- > gdhcp/client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdhcp/client.c b/gdhcp/client.c > index 3c11957..cb4bcb4 100755 > --- a/gdhcp/client.c > +++ b/gdhcp/client.c > @@ -2349,7 +2349,7 @@ static gboolean listener_event(GIOChannel *channel, > GIOCondition condition, > return TRUE; > } > > - if (!message_type && !client_id) > + if (!message_type) > /* No message type / client id option, ignore package */ > return TRUE; > Patrik _______________________________________________ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman