> > +           if (!strncmp("Already ",error,8))
> > +                   ret = -2;
> > +           else
> > +                   ret = -1;
> I don't think one can rely on the string here. It's a semi-descriptive
> one that may be used for logging or other purposes, but not much else.

Yes. A better way would be to look at DBusError.name, but that is not 
available without changing connmanctl_dbus_method_return_func_t

> The code is looking for -EINPROGRESS in dbus_method_reply(), so "proper"
> values from errno*.h shall be used. What if this just sets the return
> value to -EOPNOTSUPP?

Ok, I'll make another patch some day. 

connman mailing list

Reply via email to