Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH v3 1/9] connmand-wait-online: Add program and
initial main loop (Patrik Flykt)
2. Re: [PATCH v3 0/9] connmand-wait-online (Patrik Flykt)
3. [PATCH] connman.service: Start ConnMan after systemd-sysusers
(Patrik Flykt)
4. Re: [PATCH] doc: Fix typos in doc/vpn-config-format.txt
(Patrik Flykt)
5. Re: [PATCH] tethering: Fixed Memory Leak (Patrik Flykt)
6. [PATCH] gdbus: Move typedefs for interwork with strict
compilers (Patrik Flykt)
----------------------------------------------------------------------
Message: 1
Date: Tue, 08 Dec 2015 14:55:54 +0200
From: Patrik Flykt <[email protected]>
To: Peter Meerwald-Stadler <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v3 1/9] connmand-wait-online: Add program and
initial main loop
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Mon, 2015-12-07 at 10:25 +0100, Peter Meerwald-Stadler wrote:
> > +fail:
> > + dbus_error_free(&dbus_err);
> > +
> > + return -err;
>
> double negative
Actually yes. Normally functions return -errno on error. But exiting
main() should give 0 as success with > 0 considered errors. Combining
these two gives the above -err.
Cheers,
Patrik
------------------------------
Message: 2
Date: Tue, 08 Dec 2015 15:43:18 +0200
From: Patrik Flykt <[email protected]>
To: [email protected]
Subject: Re: [PATCH v3 0/9] connmand-wait-online
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Mon, 2015-12-07 at 10:51 +0200, Patrik Flykt wrote:
> Hi,
>
> v3 adds systemd service file to systemdunit_DATA to patch 8 as this was
> forgotten from the earlier versions. Fixed patches 4 and 5 to add 'goto free'
> to the correct patch. This latter change worked in v1 but failed in v2.
All patches applied.
Patrik
------------------------------
Message: 3
Date: Tue, 8 Dec 2015 15:44:12 +0200
From: Patrik Flykt <[email protected]>
To: [email protected]
Subject: [PATCH] connman.service: Start ConnMan after systemd-sysusers
Message-ID:
<[email protected]>
Some setups may want to define specific system users before starting
ConnMan. Order startup after systemd-sysusers.service.
---
src/connman.service.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/connman.service.in b/src/connman.service.in
index 2198a19..09dfec9 100644
--- a/src/connman.service.in
+++ b/src/connman.service.in
@@ -3,7 +3,7 @@ Description=Connection service
DefaultDependencies=false
Conflicts=shutdown.target
RequiresMountsFor=@localstatedir@/lib/connman
-After=dbus.service network-pre.target
+After=dbus.service network-pre.target systemd-sysusers.service
Before=network.target multi-user.target shutdown.target
Wants=network.target
--
2.1.4
------------------------------
Message: 4
Date: Tue, 08 Dec 2015 15:51:19 +0200
From: Patrik Flykt <[email protected]>
To: Saurav Babu <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH] doc: Fix typos in doc/vpn-config-format.txt
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Mon, 2015-12-07 at 09:12 +0530, Saurav Babu wrote:
> ---
Applied, thanks!
Patrik
------------------------------
Message: 5
Date: Tue, 08 Dec 2015 15:51:32 +0200
From: Patrik Flykt <[email protected]>
To: Saurav Babu <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH] tethering: Fixed Memory Leak
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Mon, 2015-12-07 at 11:08 +0530, Saurav Babu wrote:
> pn->owner is allocated memory but not freed in case of error.
Applied, thanks!
Patrik
------------------------------
Message: 6
Date: Tue, 8 Dec 2015 18:09:02 +0200
From: Patrik Flykt <[email protected]>
To: [email protected], [email protected]
Cc: Grant Erickson <[email protected]>
Subject: [PATCH] gdbus: Move typedefs for interwork with strict
compilers
Message-ID:
<[email protected]>
From: Grant Erickson <[email protected]>
Move enumeration type defintions AFTER the enumerations themselves are declared
and defined such that the header works with strict compilers.
This occurs when building a plugin, compiled with C++, and occurs on all of:
arm-none-linux-gnueabi-g++ (Sourcery G++ Lite 2010q1-202) 4.4.1
arm-poky-linux-gnueabi-g++ (GCC) 4.8.2
g++ (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
---
Hi,
This patch came up on the ConnMan mailing list, applies to Bluez too.
The patch is rebased to latest upstream and commit message amended with
more information.
Cheers,
Patrik
gdbus/gdbus.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index 9ece4b0..69fbc10 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -31,12 +31,6 @@ extern "C" {
#include <dbus/dbus.h>
#include <glib.h>
-typedef enum GDBusMethodFlags GDBusMethodFlags;
-typedef enum GDBusSignalFlags GDBusSignalFlags;
-typedef enum GDBusPropertyFlags GDBusPropertyFlags;
-typedef enum GDBusSecurityFlags GDBusSecurityFlags;
-typedef enum GDbusPropertyChangedFlags GDbusPropertyChangedFlags;
-
typedef struct GDBusArgInfo GDBusArgInfo;
typedef struct GDBusMethodTable GDBusMethodTable;
typedef struct GDBusSignalTable GDBusSignalTable;
@@ -120,6 +114,12 @@ enum GDbusPropertyChangedFlags {
G_DBUS_PROPERTY_CHANGED_FLAG_FLUSH = (1 << 0),
};
+typedef enum GDBusMethodFlags GDBusMethodFlags;
+typedef enum GDBusSignalFlags GDBusSignalFlags;
+typedef enum GDBusPropertyFlags GDBusPropertyFlags;
+typedef enum GDBusSecurityFlags GDBusSecurityFlags;
+typedef enum GDbusPropertyChangedFlags GDbusPropertyChangedFlags;
+
struct GDBusArgInfo {
const char *name;
const char *signature;
--
2.1.4
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 2, Issue 8
*************************************
