Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH v2 0/7] Clean up gateway selection (Patrik Flykt)
2. Re: [PATCH] client: Add support for ClearProperty Service API
(Patrik Flykt)
3. Re: [PATCH] service: Fix auto_connect service if state is not
failure and ClearProperty is called (Patrik Flykt)
----------------------------------------------------------------------
Message: 1
Date: Thu, 21 Jan 2016 11:33:59 +0200
From: Patrik Flykt <[email protected]>
To: [email protected]
Subject: Re: [PATCH v2 0/7] Clean up gateway selection
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Tue, 2016-01-19 at 13:23 +0200, Patrik Flykt wrote:
> Hi,
>
> Patch 4/7 was added to this set, it keeps service order in sync with VPN
> split routing, something that was being implicitly updated when calling
> update_order() in connection.c. The code currently already sorts the
> service list after the new calls to set_split_routing(), that's why there
> is no explicit service sorting added by patch 4/7.
>
> The rest of the patches are as before.
Applied with a bit updated commit messages.
Patrik
------------------------------
Message: 2
Date: Thu, 21 Jan 2016 11:38:11 +0200
From: Patrik Flykt <[email protected]>
To: Saurav Babu <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH] client: Add support for ClearProperty Service API
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-01-20 at 17:49 +0530, Saurav Babu wrote:
> ClearProperty API used by connman to clear the value of readonly Error
> property
> of a service. This patch adds a new config_option "clear" in the Service
> Configuration option to clear the readonly Error property.
> ---
Hmm, what would be using this functionality?
> client/commands.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/client/commands.c b/client/commands.c
> index db24d16..70e5b62 100644
> --- a/client/commands.c
> +++ b/client/commands.c
> @@ -1193,6 +1193,14 @@ static int cmd_config(char *args[], int num, struct
> connman_option *options)
> config_return, g_strdup(service_name),
> NULL, NULL);
> break;
> + case 'c':
> + res = __connmanctl_dbus_method_call(connection,
> + CONNMAN_SERVICE, path,
> + "net.connman.Service", "ClearProperty",
> + config_return, g_strdup(service_name),
> + config_append_str, &append);
> + index += append.values;
> + break;
> default:
> res = -EINVAL;
> break;
> @@ -2183,6 +2191,7 @@ static struct connman_option config_options[] = {
> {"autoconnect", 'a', "yes|no"},
> {"ipv4", 'i', "off|dhcp|manual <address> <netmask> <gateway>"},
> {"remove", 'r', " Remove service"},
> + {"clear", 'c', "Error Clear readonly Error property"},
Only 'Error' can be cleared, no arguments to be accepted. Perhaps the
option needs to be called 'clearerror' so that its meaning is clear. But
what would need this option in the first place?
> { NULL, }
> };
>
Patrik
------------------------------
Message: 3
Date: Thu, 21 Jan 2016 11:38:52 +0200
From: Patrik Flykt <[email protected]>
To: Saurav Babu <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH] service: Fix auto_connect service if state is not
failure and ClearProperty is called
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-01-20 at 17:52 +0530, Saurav Babu wrote:
> If ClearProperty method is called with property Error and service state
> other than failure then connman tries to auto_connect service if
> connect_reason was not CONNMAN_SERVICE_CONNECT_REASON_USER. This patch
> tries to run auto_connect only when service state was changed to idle
> from failure.
The commit message and the modified code seem not to address the same
thing.
> ---
> src/service.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/src/service.c b/src/service.c
> index abf0899..65439d1 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -3566,10 +3566,17 @@ static DBusMessage *clear_property(DBusConnection
> *conn,
> DBUS_TYPE_INVALID);
>
> if (g_str_equal(name, "Error")) {
> + int err;
> +
> set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
>
> - __connman_service_clear_error(service);
> - service_complete(service);
> + err = __connman_service_clear_error(service);
> +
> + if (err < 0) {
> + g_get_current_time(&service->modified);
> + service_save(service);
> + } else
> + service_complete(service);
> } else
> return __connman_error_invalid_property(msg);
>
Patrik
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 3, Issue 15
**************************************
