Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [RFC v2] connection: Move online service to ready if
gateway is removed (Naveen Singh)
2. Wifi tether without passphrase (Lad, Prabhakar)
----------------------------------------------------------------------
Message: 1
Date: Wed, 17 Feb 2016 14:52:33 -0800
From: Naveen Singh <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: [email protected]
Subject: Re: [RFC v2] connection: Move online service to ready if
gateway is removed
Message-ID:
<cagtdzkkhotu-tc6hv+ovypfq+srj+kp9vu-q_sbrt9vrmvx...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
On Fri, Feb 12, 2016 at 3:16 AM, Patrik Flykt
<[email protected]> wrote:
> When the default gateway is removed, move the service to state ready
> if the respective ipconfig was connected.
>
> Based on a patch by Naveen Singh.
> ---
>
> Coming back to the issue, downgrading the state to ready when removing the
> gateway does seem the most stable thing to do. This location to do the state
> transition was earlier proposed by Naveen Singh. In this variant the ipconfig
> state is set to ready only if it is already connected.
>
> It would be better to listen on the default routes added and removed
> when setting the state, but this has quite a few implications on testing.
> So let's try with this as a much easier working solution.
>
> Please test,
>
> Patrik
>
>
> src/connection.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/connection.c b/src/connection.c
> index 6b005e7..5234043 100644
> --- a/src/connection.c
> +++ b/src/connection.c
> @@ -963,6 +963,11 @@ void __connman_connection_gateway_remove(struct
> connman_service *service,
> if (data)
> set_default_gateway(data, type);
> }
> +
> + if (__connman_service_is_connected_state(service, type))
> + __connman_service_ipconfig_indicate_state(service,
> + CONNMAN_SERVICE_STATE_READY,
> + type);
> }
>
> bool __connman_connection_update_gateway(void)
> --
> 2.1.4
>
> _______________________________________________
> connman mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/connman
I understand this fix but it still does not fix the original issue.
The test was to let the DHCP renewal fail. Between the time device
gets a Link local and the device released its IP, the state was left
to online or ready. What we wanted the state to go to configuration
when DHCP lease renewal failed.
I was tracing the code path and this was happening:
1) dhcp_callback in network.c gets called from dhcp state machine
after losing the lease.
2) Since it is a failure case, dhcp_failure gets called
3) From dhcp_failure we call __connman_ipconfig_gateway_remove which
ends up calling __connman_connection_gateway_remove.
Now with your fix that you suggested even though we have cleared IPv4
address we are still making the state as READY which probably is not
the right thing to do. Do you think doing a state machine transition
from dhcp_failure to CONFIGURATION is the right thing to do?
Let me know your thoughts on this.
Regard
------------------------------
Message: 2
Date: Thu, 18 Feb 2016 11:11:30 +0000
From: "Lad, Prabhakar" <[email protected]>
To: [email protected]
Subject: Wifi tether without passphrase
Message-ID:
<ca+v-a8uphoftukdzccxxxanyqlxagng0pw3kyy7yswqqrcy...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Hi,
Is there a way to create a AP without a hotspot ? Like we have open
networks which we can connect to them without passwords.
connmanctl tether wifi on SSID
Cheers,
--Prabhakar
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 4, Issue 21
**************************************
